Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhost: add file downloads to the room api endpoint #2780

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Webhost: add file downloads to the room api endpoint #2780

merged 5 commits into from
Apr 11, 2024

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

title. also removes the unused ds3 download link

How was this tested?

checked that the links at the api endpoint matches those that get generated on the room page.

If this makes graphical changes, please attach screenshots.

@alwaysintreble alwaysintreble added is: enhancement Issues requesting new features or pull requests implementing new features. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Jan 30, 2024
@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
qwint
qwint approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@qwint qwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally hosted on 3.11 and 3.8 using a seed that has a SMW patch file
confirmed that with the roomId and knowing your slot number you can find the download link for your relevant game (compared with the one in the room UI) in /api/room_status/{roomId}

I'm not sure how a game is supposed to get that roomId to make the api useful, but i'm assuming it's related to #2779

@alwaysintreble
Copy link
Collaborator Author

alwaysintreble commented Mar 12, 2024 •
edited
Loading

I'm not sure how a game is supposed to get that roomId to make the api useful, but i'm assuming it's related to #2779

The room suuid is in the url queries in #2779. It probably makes more sense to just add that specific query here, but the passed url already had to be modified in that PR so I just added it instead of creating merge conflicts.

@qwint
Copy link
Contributor

qwint commented Mar 12, 2024

ah yea, double checked and it's passed in plain as day
i forgot about that because my last slew of testing on #2779 was manually writing the urls into launcher.py parameters to make sure my game was configured right, whoops

@alwaysintreble alwaysintreble added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 26, 2024
@Berserker66 Berserker66 merged commit 5d4ed00 into ArchipelagoMW:main Apr 11, 2024
15 checks passed
@alwaysintreble alwaysintreble deleted the room_files_api branch April 11, 2024 03:12
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@alwaysintreble @EmilyV99
Webhost: add file downloads to the room api endpoint (ArchipelagoMW#2780
bbd8fc1 
)
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@alwaysintreble @EmilyV99
Webhost: add file downloads to the room api endpoint (ArchipelagoMW#2780
b71c2be 
)
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@alwaysintreble @qwint
Webhost: add file downloads to the room api endpoint (ArchipelagoMW#2780
1574a42 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwint qwint qwint approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alwaysintreble @qwint @Berserker66 @PoryGone